-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve presentation of matching results and related #451
Conversation
"move": * column in editors may be different if there are tabs * short * avoids confusion with position or offset
* added for notepad++, UltraEdit and Notepad2 * removed CodeWright due to fade out of the stage * Notepad2: match only current line highlighted * refactor to reduce codes
and move `linePositions` from public into the function
* `%30s` adds space prefix if the length < 30, remove width specification * show the match with a prefix context, in case of at a long line end, even offset > 259 * in content mode, show content starting from the line pointed to * increase the max picked length to 50
now we have the 2nd indicator "move" (offset in the line) and highlight
why do you call it "move"? Isn't this the column of the line? |
Many people take int i = 0; Here we can only say BTW: |
I called it "column" at first. |
while "caret move" would be better than just "move", I don't think either is good. It's not a common term for what it is used for. I myself had no idea what this "move" should be before checking the source code. |
None is perfect. I don't have a better one. So, it will be changed back to "column", and with explanation "line offset". |
* "move" is not common, just "column" with "in line offset" as explanation * the columns that a `\t` counts depends on editors. We take it as 1.
#83, #117 and more. See the descriptions of each commit.